Activity for Dan Eble
-
Dan Eble modified ticket #5934
remove Repeated_music::folded_music_length
-
commit 6ab4eea9b05e34e159d580469c2d6c12cb4bcfc3 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Fri Apr 24 21:57:34 2020 -0400
-
ly:performance-headers and \midi { after-writing }
-
commit 26bc68381e1f36846cef87d8cf0fe74585b39b63 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Tue Apr 14 22:52:06 2020 -0400 Issue 5917: ly:performance-headers and \midi { after-writing } Change ly:performance-header into ly:performance-headers, returning a list of visible header modules from innermost to outermost. Before, only the innermost header was provided, so the values of variables defined in outer headers were not accessible. If the \midi block defines a function called after-writing,...
-
ly:performance-headers and \midi { after-writing }
-
I'm getting a new warning from slur-scoring today: Making lily/out/slur-scoring.o < cc /home/user/lilypond-src/lily/slur-scoring.cc: In static member function 'static scm_unused_struct* Slur::calc_control_points(SCM)': /home/user/lilypond-src/lily/slur-scoring.cc:390:45: warning: format '%d' expects argument of type 'int', but argument 3 has type 'size_t' {aka 'long unsigned int'} [-Wformat=] 390 | total += to_string (" TOTAL=%.2f idx=%d", best->score (), best->index_); | ~^ ~~~~~~~~~~~~ | | | |...
-
remove unnecessary (descend-to-context ... 'Score)
-
commit 0e78335e8ebb2d2c6c677280695ef1ae7c787740 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Mon Feb 17 14:52:03 2020 -0500 Issue 5771/2: simplify make-time-signature-set Remove an unnecessary (descend-to-context ... 'Score). commit c325d5159d49afb04b57ecaa6e67be359a50ad9e Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Mon Feb 17 11:49:41 2020 -0500 Issue 5771/1: simplify \partial Remove an unnecessary (descend-to-context ... 'Score).
-
Add \post to defer context actions to end of time step
-
make-time-signature-set https://codereview.appspot.com/557440043
-
improve Rational infinity initialization
-
commit cf4876d3990fbebdb240f17ebfba4f262643a0d7 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Wed Mar 25 19:12:53 2020 -0400 Issue 5864/3: Rational: handle init by double +/- infinity commit a90108c38d995c32efd4d19be8ec4bdb057fb181 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Wed Mar 25 19:10:10 2020 -0400 Issue 5864/2: Rational: handle init by (nonzero, 0) as +/- infinity commit 1b6e3948c06081f5a43e3e4af5607fc59f26c94e Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Wed...
-
I compared the output of 2.20 v. master for all my scores today. Overall, I'm pleased with the impact of this change, but it's not all roses. (In the attached image, green is 2.20 and red is master.)
-
I compared the output of 2.20 v. master for all my scores today. Overall, I'm pleased with the impact of this change, but it's not all roses.
-
improve Rational infinity initialization
-
I'll push this after 2.21.0 is released.
-
Prefer astyle 3.1 and update clang-format options
-
commit f2b0913e93ce24fee9e15e071c42f5d1aee54240 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Mon Mar 23 20:35:48 2020 -0400 Issue 5862/2: adjust clang-format options Add a few clang-format options to reduce (slightly) the extent of changes that a subsequent fixcc.py makes. ... commit 0731c054e413f78e29eee89e44f4fb40ae5bb268 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Sun Mar 22 18:03:57 2020 -0400 Issue 5862/1: Change preferred version of astyle from 2.04 to 3.1
-
Prefer astyle 3.1 and update clang-format options
-
output-distance: avoid calling strip() on None
-
Please do not push. I've asked in the review for more information about how this has been tested and how it now treats a couple of different cases of differences in the test output.
-
Rational conversion clean-up
-
commit 1a061b0d2b7e3b50c8f2846008882325dfe1fec8 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Sat Feb 22 22:10:33 2020 -0500 Issue 5790/8: Rational: to_int () becomes trunc_int () ... and returns I64 like num () and den (). commit f0e68ea3a9c8db6d7b81a3f7fd797804b26c9cbf Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Sat Feb 22 12:53:31 2020 -0500 Issue 5790/7: Rational: disable implicit conversion to double This helps emphasize places where exactness might be lost. commit 95bf2fde4b95969875dd2cfe96b4424175ca3885...
-
fix various warnings
-
commit 6e6b834a5cd10f33d427da7253568216cc673e1f (origin/staging) Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Sat Feb 15 13:21:20 2020 -0500 Issue 5766/5: int->vsize to fix warning in pointer-group-interface commit ecb1b3eb2a18bb19e39d57dda17fecb2011a9dea Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Sat Feb 15 13:21:31 2020 -0500 Issue 5766/4: int->vsize to fix warning in global-context commit ae0fae9f577ab3ad7597cba59bb22faa55874737 Author: Dan Eble <nine.fierce.ballads@gmail.com>...
-
Another workaround to consider: insert \partial 1024 s1024 after the cadenza. Mid-piece \partial was not supported at the time this issue was reported.
-
\post would indeed offer some options to a person irked by [#1543]. (I admit it's not the most compelling case.)
-
\break \bar "|:" \set Score.skipTypesetting = ##t The prototype implementation of the \post function proposed in [#5740], when applied to this \set command, makes the line break appear in the visual score.
-
\post might be the missing piece preventing \partial from being implemented with ly + scm Not the only missing piece. It looks like expressing what Partial_iterator does would also require alternative music that is iterated conditionally based on a test that occurs in context, something like this: \context Timing \selectInContext #after-start << { \once \set Timing.partialBusy = ##t \post \applyContext #apply-partial-after-start } { \applyContext #apply-partial-at-start } >> The effect of \selectInContext...
-
Understood. Using the tracker this way is the easiest way for me to make sure it doesn't go in ahead of schedule. If this were blocking other work, I'd argue, but it's pretty unimportant.
-
remove unnecessary (descend-to-context ... 'Score)
-
David wants this change to wait for 2.21.1. It would also be a good idea to look for other places where the same change could be made.
-
Fix various type-conversion warnings
-
commit 7362fcde459d888f40523624db9e60cf9a369d48 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Mon Feb 3 15:08:08 2020 -0500 Issue 5733/4: int->vsize in Dot_column fixes warning commit e302af56687111bcc2a8db883b2478d8fc642ced Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Sun Feb 2 15:57:12 2020 -0500 Issue 5733/3: Fix type-conversion warning in Scale Assert that scale size is less than the max int value. commit 4951c5b23a1ec650476f6a42d3cf335457619094 Author: Dan Eble <nine.fierce.ballads@gmail.com>...
-
commit d8df79db7776e4f635f4dd01f1cbfb0582aaf0d2 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Mon Feb 3 15:46:24 2020 -0500
-
Silence warning in Stem::get_beaming ()
-
commit d8df79db7776e4f635f4dd01f1cbfb0582aaf0d2 Author: Dan Eble nine.fierce.ballads@gmail.com Date: Mon Feb 3 15:46:24 2020 -0500
-
Fix input/regression/context-find-parent.ly
-
commit 5839c5a5abd294b587b43d77fab32a9d10b81836 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Wed Jan 22 15:18:38 2020 -0500
-
Looking at partial-iterator.cc, I think that \post might be the missing piece preventing \partial from being implemented with ly + scm. I'm going to experiment with that.
-
Looking at partial-iterator.cc, I think that \post might be the missing piece preventing it from being implemented with ly + scm. I'm going to experiment with that.
-
"What I'd expect from reading the test" is what I was hoping for. There was plenty of attention when this test and others were created. I'll push this change soon and then celebrate the end of a big unplanned task that has been a long time in coming. Thanks!
-
Use unique_ptr in layout code
-
commit 011a4593fcc6450e9cb1fc0fff9bc3e5b1395a9b Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Sun Feb 2 21:42:06 2020 -0500 Issue 5732/4: Use unique_ptr for Slur_configuration commit e42552f5fac039a73018d2fcb4a11f0fc1a7b9f7 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Sun Feb 2 21:50:50 2020 -0500 Issue 5732/3: Use unique_ptr in Bracket_nesting_group commit 92590f43038b346a8fb6b1901cdf92f2e193a327 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Sun Feb 2 22:05:42 2020 -0500...
-
Pedal_type_info maintenance
-
commit 1ca89d95f9385c7c7cea2c52ecf1df63ef45be3e Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Sat Feb 1 12:39:18 2020 -0500 Issue 5723/2: Pedal_type_info: use std::string instead of dubious strdup commit 40974cdd62519b27f0ab21a45c678d61c7e72dc1 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Sat Feb 1 12:38:34 2020 -0500 Issue 5723/1: Pedal_type_info: use C++11 member default values
-
"skipTypesetting doesn't behave well on its margins" [#1543] looks interesting.
-
One application I can think of may be the end of a \cadenza coinciding with a new bar start. \partial 0*1 does not work for that and it's super awkward to get this to work. Thanks. I understand these words, but not enough to tell what you have in mind as the problem to be solved. I searched the issues for "cadenza" and came up with "Accidentals don't reset after explicit barlines" [#3640], but I don't see promise for a \post command to improve that.
-
Autobeam setting should be reverted to setting before cadenza
-
This request seems irrelevant after [#3633].
-
My request was unclear. I'm asking for someone to look at the test case and judge whether the new actual output is the expected output. Yes, it's different than the previous actual output—but is it now correct? I believe it is correct, but I want to set an example of getting appropriate feedback before breaking from the normal routine and pushing early.
-
Please don't lengthen the countdown. My request for feedback was aimed toward justifying accelerating it rather than signalling a lack of confidence that it's good. I don't want to jump the queue unilaterally, even when I'm confident. Thanks.
-
Add \post to defer context actions to end of time step
-
That's the expected change. I would appreciate independent confirmation; is anyone interested in taking a little time to understand the case? After that, I think it will make sense to push this, since the code was reviewed last week and is just enabled by this patch.
-
Does it work like once, setting a property on a stream event? That would seem important for quoted music and the part combiner. Yes.
-
Add \post to defer context actions to end of time step
-
Add makefile targets for formatting all C++ code
-
To be clear about this, if it appears to be half baked, and you don't want half-baked stuff to go in, I won't be offended if you want me to mark it "needs work." This is something that was helpful to me which I thought might be helpful to others interested in bringing the clang-format config to the point that it can be trusted. That's all.
-
... as well as checking style of changed files automatically as part of make check.
-
I have approached this from the perspective that it might grow to handle use cases like style is good edit some files run the target to restyle changed files (not all 700-some) goto 2
-
Generalize context searches
-
commit ee162c3ea7894868d1dee6b2af5f32a17ebdbd71 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Thu Jun 28 19:56:29 2018 -0400 Issue 5362/3: Change descend-only to search-direction It is now a direction rather than a boolean. commit 9c203228cf6b6f7173182d8d935337ef26544ea9 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Wed Jan 22 14:33:39 2020 -0500 Issue 5362/2: Generalize context searches Combine code for \new, \context, and various internal searches. This includes a small block...
-
commit 0131ee27834773218d089a77d7253309c79ff8f5 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Thu Jan 23 18:40:35 2020 -0500
-
Split context_specification syntax constructor
-
commit 0131ee27834773218d089a77d7253309c79ff8f5 (HEAD, origin/staging) Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Thu Jan 23 18:40:35 2020 -0500
-
Tie formatting maintenance
-
commit 937e413c0f399b2ec44785b7ca29d61cf7b24cff Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Fri Jan 31 13:48:35 2020 -0500 Issue 5719/4: Tie_formatting_problem: [i] instead of at (i) ... in loops where it is clear that the index is in bounds. at () checks the index, which is unnecessary in these places. commit 6321ffc39a276d0de4b13bfa105fbc7940278959 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Fri Jan 31 11:54:18 2020 -0500 Issue 5719/3: ties->front () instead of ties->at (0)...
-
Remove likely dead code from set_property_from_event
-
commit d6956e8ed6da831574cd9bcadb05ac0c47c84a07 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Thu Jan 30 17:38:20 2020 -0500
-
implement suggestions https://codereview.appspot.com/565610043
-
commit f20eed0b629bbc1404e8b37b91d4df296aff1483 (origin/staging) Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Mon Feb 3 15:31:52 2020 -0500 Revert "Issue 5705: int->long in Stem::get_beaming and set_beaming" This reverts commit bd1866921efe6b0ffbc51c83dc2c2bb64f3fc583.
-
Silence warning in Stem::get_beaming ()
-
Issue 5705: Cast to silence warning in Stem::get_beaming () https://codereview.appspot.com/565610043
-
fix \cueDuring and \quoteDuring display test
-
commit 4931993b9761e85943b4fdfa5a392f3a3ba76831 (origin/staging) Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Tue Jan 28 16:41:01 2020 -0500 Issue 5707/2: Treat warnings as errors in display-lily-tests.ly ... so that bugs will not be overlooked. commit ca98f4ed155e5a73d5d8af4c12fedc54a9aed289 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Tue Jan 28 21:49:38 2020 -0500 Issue 5707/1: Fix \cueDuring and \quoteDuring display Remove a hash mark that was acceptable, but not ideal.
-
int->long in Stem::get_beaming and set_beaming
-
commit bd1866921efe6b0ffbc51c83dc2c2bb64f3fc583 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Fri Dec 6 18:07:47 2019 -0500
-
int->vsize in various alignment and page-layout methods
-
commit 20050ccd133b0886da658cfa7172bcd56e046255 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Tue Jan 7 11:53:18 2020 -0500
-
Generalize context searches
-
Issue 5362: Generalize context searches 1: Add Context::matches () This method answers the central question of a context search: is this what I'm looking for? Its use will increase in later commits. 2: Generalize context searches Combine code for \new, \context, and various internal searches. This includes a small block of disabled code which will fix input/regression/context-find-parent.ly once it is enabled. input/regression/context-descend-only-not-found.ly shows that a defect in the descend-to-context...
-
reduce dynamic casting
-
commit 15490d9cd052bd3b59307f4c80543b6671298601 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Fri Jun 8 16:23:21 2018 -0400 Issue 5695/3: reduce unsmobbing in Paper_column::is_musical commit c97fe97dd3b4c449accb3f057d61b5f32095e6b3 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Fri Jun 8 16:23:21 2018 -0400 Issue 5695/2: reduce unsmobbing in Spaceable_grob::get_spring commit 67b67a89f6c9e31b0726c6482c3e48c9b708ee4b Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Fri Jun 8...
-
Dot_configuration maintenance
-
commit cd83bbc1eb44224ab3c0268d78a862e3d9987988 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Mon Nov 4 18:51:53 2019 -0500 Issue 5694/5: Dot_configuration "has a" instead of "is a" std::map It is considered poor form to create subclasses of standard containers because they lack virtual destructors. Inheriting privately from std::map avoids potential problems by preventing Dot_configuration from being treated as a std::map from the outside. (I didn't find any actual problems in this case.)...
-
Refactor enforcement of a single Score context
-
commit 5e40b2af5005e1fd1d0bee225b55ef544be80631 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Fri Jan 17 22:22:33 2020 +0100 Issue 5689: Refactor enforcement of a single Score context ...
-
fix \cueDuring and \quoteDuring display test
-
simplify Spaceable_grob::get_spring https://codereview.appspot.com/575530107
-
Avoid "using" directives in included files
-
commit 00929c7b4bbd276e82cb392dfbada0f408204778 (HEAD -> dev/issue-4550-using-namespace-std, origin/staging) Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Wed Jan 22 08:23:59 2020 -0500 Issue 4550/3: Remove remaining "using namespace std;" with a script The script is posted in the code review: https://codereview.appspot.com/579240043/ commit 6f4128e1f359daf38a3caf2c0e4ad68e16c10540 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Thu Jan 9 13:04:18 2020 -0500 Issue 4550/2: Avoid "using...
-
Create Bottom contexts in a more general way
-
Avoid "using" directives in included files
-
Issue 4550: Avoid "using namespace std;" in included files https://codereview.appspot.com/579240043
-
Fix some conversion warnings in Source_file.
1 >
