Menu ▾ ▴

#5917 ly:performance-headers and \midi { after-writing }

Fixed
Dan Eble
Fixed_2_21_1 (43)
Enhancement
2020-04-23
2020-04-18
Dan Eble
No

Change ly:performance-header into ly:performance-headers, returning a
list of visible header modules from innermost to outermost. Before,
only the innermost header was provided, so the values of variables
defined in outer headers were not accessible.

If the \midi block defines a function called after-writing, LilyPond
calls it after writing the MIDI file. Apart from its use in regression-
testing ly:performance-headers, it offers a way for an advanced user to
dump metadata associated with each performance. For example, the
function could open a file and dump all header variables in YAML format
for use in a scripted workflow where the information ends up in ID3 tags
in an mp3 file.

https://codereview.appspot.com/567450043

Discussion

  • Anonymous

    Anonymous - 2020-04-18

    Passes make, make check and a full make doc - reg test diff attached

     
    Thumbnail
    Screenshot from 2020-04-18 18-54-02.png

  • Anonymous

    Anonymous - 2020-04-18
    • Description has changed:

    Diff:
    • Needs: -->
    • Patch: new --> review
     

  • Anonymous

    Anonymous - 2020-04-21
    • Patch: review --> countdown
     

  • Anonymous

    Anonymous - 2020-04-21

    Patch on countdown for April 23rd

     

  • Dan Eble

    Dan Eble - 2020-04-21
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,6 +1,6 @@
 Change ly:performance-header into ly:performance-headers, returning a
 list of visible header modules from innermost to outermost.  Before,
-only the innermost header was provided, so it the values of variables
+only the innermost header was provided, so the values of variables
 defined in outer headers were not accessible.

 If the \midi block defines a function called after-writing, LilyPond
     

  • Anonymous

    Anonymous - 2020-04-23
    • Patch: countdown --> push
     

  • Anonymous

    Anonymous - 2020-04-23

    Patch counted down - please push.

     

  • Dan Eble

    Dan Eble - 2020-04-23
    • labels: --> Fixed_2_21_1
    • status: Started --> Fixed
    • Patch: push -->
     

  • Dan Eble

    Dan Eble - 2020-04-23 
    commit 26bc68381e1f36846cef87d8cf0fe74585b39b63
Author: Dan Eble <nine.fierce.ballads@gmail.com>
Date:   Tue Apr 14 22:52:06 2020 -0400

    Issue 5917: ly:performance-headers and \midi { after-writing }

    Change ly:performance-header into ly:performance-headers, returning a
    list of visible header modules from innermost to outermost.  Before,
    only the innermost header was provided, so the values of variables
    defined in outer headers were not accessible.

    If the \midi block defines a function called after-writing, LilyPond
    calls it after writing the MIDI file.  Apart from its use in regression-
    testing ly:performance-headers, it offers a way for an advanced user to
    dump metadata associated with each performance.  For example, the
    function could open a file and dump all header variables in YAML format
    for use in a scripted workflow where the information ends up in ID3 tags
    in an mp3 file.
     
MongoDB Logo MongoDB