I didn't want to imply that it's not fit for review. Just that waiting with actually pushing it could result in a better chance at locating a culprit (not even necessarily this patch) when at some significant distance in time something out of kilter with the context system is discovered. But if you can find something sensible of the same kind that may warrant combining, that's also fine.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Understood. Using the tracker this way is the easiest way for me to make sure it doesn't go in ahead of schedule. If this were blocking other work, I'd argue, but it's pretty unimportant.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Anonymous
-
2020-02-17
Passes make, make check and a full make doc
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Diff:
David wants this change to wait for 2.21.1.
It would also be a good idea to look for other places where the same change could be made.
I didn't want to imply that it's not fit for review. Just that waiting with actually pushing it could result in a better chance at locating a culprit (not even necessarily this patch) when at some significant distance in time something out of kilter with the context system is discovered. But if you can find something sensible of the same kind that may warrant combining, that's also fine.
Understood. Using the tracker this way is the easiest way for me to make sure it doesn't go in ahead of schedule. If this were blocking other work, I'd argue, but it's pretty unimportant.
Passes make, make check and a full make doc
make-time-signature-set
https://codereview.appspot.com/557440043
Passes make, make check and a full make doc
Patch on countdown for April 15th
Patch counted down - please push.
commit 0e78335e8ebb2d2c6c677280695ef1ae7c787740 Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Mon Feb 17 14:52:03 2020 -0500 Issue 5771/2: simplify make-time-signature-set Remove an unnecessary (descend-to-context ... 'Score).commit c325d5159d49afb04b57ecaa6e67be359a50ad9e Author: Dan Eble <nine.fierce.ballads@gmail.com> Date: Mon Feb 17 11:49:41 2020 -0500 Issue 5771/1: simplify \partial Remove an unnecessary (descend-to-context ... 'Score).