Menu

#5864 improve Rational infinity initialization

Fixed
Dan Eble
Enhancement
2020-04-10
2020-03-26
Dan Eble
No

1: take advantage of C++11 in real.hh
(this is a tangent)

2: handle init by (nonzero, 0) as +/- infinity

3: handle init by double +/- infinity

https://codereview.appspot.com/577710043

Discussion

  • Anonymous

    Anonymous - 2020-03-26
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2020-03-26

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2020-03-28
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2020-03-28

    Patch on countdown for March 29th

     
  • Anonymous

    Anonymous - 2020-03-29
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2020-03-29

    Patch counted down - please push

     
  • Dan Eble

    Dan Eble - 2020-03-29
    • Patch: push --> waiting
    • Type: --> Enhancement
     
  • Dan Eble

    Dan Eble - 2020-03-29

    I'll push this after 2.21.0 is released.

     
  • Dan Eble

    Dan Eble - 2020-04-10
    • labels: --> Fixed_2_21_1
    • status: Started --> Fixed
    • Patch: waiting -->
     
  • Dan Eble

    Dan Eble - 2020-04-10
    commit cf4876d3990fbebdb240f17ebfba4f262643a0d7
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Wed Mar 25 19:12:53 2020 -0400
    
        Issue 5864/3: Rational: handle init by double +/- infinity
    
    commit a90108c38d995c32efd4d19be8ec4bdb057fb181
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Wed Mar 25 19:10:10 2020 -0400
    
        Issue 5864/2: Rational: handle init by (nonzero, 0) as +/- infinity
    
    commit 1b6e3948c06081f5a43e3e4af5607fc59f26c94e
    Author: Dan Eble <nine.fierce.ballads@gmail.com>
    Date:   Wed Mar 25 18:56:29 2020 -0400
    
        Issue 5864/1: take advantage of C++11 in real.hh