Add tab icons to Filter dialog
Windows visual diff and merge for files and directories
Brought to you by:
christianlist,
grimmdp
Menu
▾
▴
#2513 Add tab icons to Filter dialog
This patch adds icons to the tabs from the filter dialog. So we have also a graphical way to show if it's about "files" or "lines". (See the example screenshot.)
Is the patch simple enough for WinMerge 2.8?
Greetings,
Tim
Btw: Would be "LineFiltersDlg.cpp" not a better name for the file "PropLineFilter.cpp"?
original and altered files
Logged In: YES
user_id=652377
Originator: YES
File Added: filter_dialog_tab_icons.png
example screenshot
Logged In: YES
user_id=652377
Originator: YES
And maybe we could use the file filter icon instead of "[F]" in the filter combo box?
RFE #1926550 "Use icons instead of '[F]' in filter combo box"
http://winmerge.org/rfe/1926550
Logged In: YES
user_id=631874
Originator: NO
Nice and simple, so good for trunk.
No 2.8 branch now, but probably after 2.8.0 and for 2.8.2. I want to be careful and not cause some graphic bug just before a big release, so some testing in trunk is good.
> Btw: Would be "LineFiltersDlg.cpp" not a better
> name for the file "PropLineFilter.cpp"?
Yes. Line filter dialog was (as name suggests) part of options dialog in old WinMerge releases, but got then moved to own filter dialog. I didn't change the file name as changing filenames was pretty hard with CVS.
Logged In: YES
user_id=652377
Originator: YES
Committed to SVN (Trunk, In Revision 5193).
Leave open for maybe WinMerge 2.8.2.
Logged In: YES
user_id=652377
Originator: YES
Committed to SVN (Branch R2_8, In Revision 5349)...