Migrate from GitHub to SourceForge with this tool. Check out all of SourceForge's recent improvements.
Close

#2513 Add tab icons to Filter dialog

Trunk
closed-fixed
GUI (476)
5
2008-05-19
2008-03-26
Tim Gerundt
No

This patch adds icons to the tabs from the filter dialog. So we have also a graphical way to show if it's about "files" or "lines". (See the example screenshot.)

Is the patch simple enough for WinMerge 2.8?

Greetings,
Tim

Btw: Would be "LineFiltersDlg.cpp" not a better name for the file "PropLineFilter.cpp"?

Discussion

  • Tim Gerundt

    Tim Gerundt - 2008-03-26

    Logged In: YES
    user_id=652377
    Originator: YES

    File Added: filter_dialog_tab_icons.png

     
  • Tim Gerundt

    Tim Gerundt - 2008-03-26

    Logged In: YES
    user_id=652377
    Originator: YES

    And maybe we could use the file filter icon instead of "[F]" in the filter combo box?

    RFE #1926550 "Use icons instead of '[F]' in filter combo box"
    http://winmerge.org/rfe/1926550

     
  • Kimmo Varis

    Kimmo Varis - 2008-03-26

    Logged In: YES
    user_id=631874
    Originator: NO

    Nice and simple, so good for trunk.

    No 2.8 branch now, but probably after 2.8.0 and for 2.8.2. I want to be careful and not cause some graphic bug just before a big release, so some testing in trunk is good.

    > Btw: Would be "LineFiltersDlg.cpp" not a better
    > name for the file "PropLineFilter.cpp"?
    Yes. Line filter dialog was (as name suggests) part of options dialog in old WinMerge releases, but got then moved to own filter dialog. I didn't change the file name as changing filenames was pretty hard with CVS.

     
  • Tim Gerundt

    Tim Gerundt - 2008-03-26
    • status: open --> open-accepted
     
  • Tim Gerundt

    Tim Gerundt - 2008-03-26

    Logged In: YES
    user_id=652377
    Originator: YES

    Committed to SVN (Trunk, In Revision 5193).

    Leave open for maybe WinMerge 2.8.2.

     
  • Tim Gerundt

    Tim Gerundt - 2008-03-26
    • assigned_to: nobody --> gerundt
     
  • Tim Gerundt

    Tim Gerundt - 2008-05-19

    Logged In: YES
    user_id=652377
    Originator: YES

    Committed to SVN (Branch R2_8, In Revision 5349)...

     
  • Tim Gerundt

    Tim Gerundt - 2008-05-19
    • status: open-accepted --> closed-fixed
     

Log in to post a comment.