[xine-devel] Still I frame bug

[Nathan K. <nk...@cs...>]

Hi,

  On a couple of dvds there seem to be some standalone I frames used for
menus, which libmpeg2 is discarding for some reason that I admit I don't
really understand (not an mpeg2 expert). Patch below, doesn't seem to
break anything afaict.

  This doesn't actually fix any of the discs in question[0] as there's
still a major timing problem I'm trying to track down, but at least this
gets the menu frame into the video queue[1]

Regards,
Nathan

[0] "Tenchi Muyo: Ultimate Collection" discs 1 & 2 are what I'm mainly
    debugging with, as they have the unique feature of starting straight
    at the menu with no pre-menu titles.
[1] whereupon it then gets immediately discarded[2] for being highly
    obsolete, but like I said, I'm still looking into this. (although any
    suggestions appreciated)
[2] hacking around this to force the first frame of the stream to
    always display does make the main menu display nicely, sans
    highlights, although doesn't help with the submenus.

---
Index: decode.c
===================================================================
RCS file: /cvsroot/xine/xine-lib/src/libmpeg2/decode.c,v
retrieving revision 1.33
diff -u -w -b -r1.33 decode.c
--- decode.c    2001/10/20 02:01:51     1.33
+++ decode.c    2001/10/26 13:57:31
@@ -121,6 +121,8 @@
              picture->throwaway_frame = NULL;
            } else if (picture->forward_reference_frame) {
              mpeg2dec->frames_to_drop = picture->forward_reference_frame->draw (picture->forward_reference_frame);
+           } else {
+             picture->current_frame->draw(picture->current_frame);
            }
 #ifdef ARCH_X86
---