Re: [xine-user] subpictures

[Rich W. <rj...@he...>]

On Fri, 30 Mar 2001, Guenter Bartsch wrote:

> Hi folks,
> 
> while further cleaning up the xine code I noticed that the subpicture code
> is spread over several modules (libspudec (where it belongs), xine.c and
> video_out.c).
> 
> So I decided to radically change this, moved all the code to libspudec and
> stripped down the interface - so, has anybody comments about this? Take a
> look at spudec.h - Rich, do you think your code could be re-written to fit
> this interface?

I don't see why not. I notice that you have packets arriving in a FIFO
buffer. I have a couple of queries.

1) I take it that it is the demuxers resonsibility to collect together the
appropriate fragmets of the packet. That was originally done from within
libspudec, or does the FIFO buffer consist of a sequence of packet
fragments as they come out of the MPEG stream. Where is the packet
collection doe for AC3? ISTR that the demuxer passes the fragments
directly to ac3dec.

2) Is the SPU decoding still to be done in a seperate thread or as part of
the video decoding?

3) The FIFO containing the SPU packets will either have to be a) polled by
the SPU thread or b) a function added to spudec.h to tell libspudec that
interesting stuff has arrived in the buffer (or is there already a 'data
has entered the buffer' callback mechanism to the FIFO buffer stuff I
wasn't aware of?)

Aside from 3) particularly I think that the original spudec stuff will fit
into this quite neatly. 

Rich

-- 
rich

The box says 'Requires Win95 or better' so it /must/ run under Linux