Menu
▾
▴
[xine-bugs] [ xine-Bugs-1478367 ] Plugin libraries unnecessarily export internal symbols
|
From: SourceForge.net <no...@so...> - 2006-05-09 22:19:43
|
Bugs item #1478367, was opened at 2006-04-28 13:35 Message generated for change (Comment added) made by richardash1981 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=109655&aid=1478367&group_id=9655 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: build system problem Group: v1.1.1 Status: Open Resolution: None Priority: 5 Submitted By: Pete Chapman (ao8hylz02) Assigned to: Nobody/Anonymous (nobody) Summary: Plugin libraries unnecessarily export internal symbols Initial Comment: I have seen a problem where an application (amarok) uses both libmad and libxine, and ends up mistakenly calling the internal mad_* functions in xineplug_decode_mad.so. In my case it caused the application to segfault. As far as I can tell, only the xine_plugin_info struct needs to be exported from *any* of the plugins. So it seems to me that all of the plugin libraries should be built with -fvisibility=hidden, and the xine_plugin_info struct explicitly exported - because at the moment the libraries are polluting the global namespace with their internal implementation details. I originally noticed the problem here: http://qa.mandriva.com/show_bug.cgi?id=21567 ---------------------------------------------------------------------- Comment By: Richard Ash (richardash1981) Date: 2006-05-09 23:19 Message: Logged In: YES user_id=950206 Gentoo has a similar patch on the FAAD module to cure another Amrock crash: http://bugs.gentoo.org/show_bug.cgi?id=112921 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=109655&aid=1478367&group_id=9655 |