[xine-bugs] [ xine-Bugs-1262477 ] Failure to recognize aac in mkv container

[SourceForge.net <no...@so...>]

Bugs item #1262477, was opened at 2005-08-17 12:55
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109655&aid=1262477&group_id=9655

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: demuxer (stream type support)
Group: current cvs version
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Failure to recognize aac in mkv container

Initial Comment:
Hello.  
  
I have some matroska videos that  
contain aac audio tracks. However, the xine mkv 
demuxer fails to recognize the aac tracks. I 
poked around and created a patch that fixes the 
problem (attached). 
 
The problem is that recognizing an aac stream 
requires checking that the prefix of the codec id 
is "A_AAC/". However, taking the 'sizeof' the 
constant string (that appears to be what the 
code is trying to do) clearly isn't figuring out the 
number of characters (doesn't seem surprising 
to me). 
 
The patch replaces the sizeof expression directly 
with the number of characters in the codec id 
prefix: 6. I realize this might not be an optimal 
solution, but at least this points out the area 
where the bug exists, so you can fix it as you 
like. :) 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109655&aid=1262477&group_id=9655