[xine-bugs] [ xine-Bugs-977510 ] bug in quicktime refmovie parser

[SourceForge.net <no...@so...>]

Bugs item #977510, was opened at 2004-06-22 16:19
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109655&aid=977510&group_id=9655

Category: xine
Group: v1-rc5
Status: Open
Resolution: None
Priority: 5
Submitted By: Nik Soggia (crimex)
Assigned to: Nobody/Anonymous (nobody)
Summary: bug in quicktime refmovie parser

Initial Comment:
Hello everybody,
I set up a test refmovie (built with MakeRefMovie) that
triggers a bug in parse_reference_atom(), try to open
this URL with xine:
http://www.niksoggia.it/xine/xine_ref_atom_bug.qt

parse_reference_atom() acts as if the URL in the
refmovie was relative, because the "http://" string is
at ref_atom[i+16] and not at ref_atom[i+12]. The
solution of the problem should be quite trivial:

SAFER:

--- src/demuxers/demux_qt.c     2004-06-15
23:22:34.000000000 +0200
+++ src/demuxers/demux_qt.new1.c        2004-06-22
14:42:29.000000000 +0200
@@ -1459,6 +1459,8 @@
                                                      
                                                      
              
       /* if the URL starts with "http://", copy it */
       if (strncmp(&ref_atom[i + 12], "http://", 7) == 0
+        || strncmp(&ref_atom[i + 12], "rtsp://", 7) == 0
+        || strncmp(&ref_atom[i + 16], "http://", 7) == 0
         || strncmp(&ref_atom[i + 16], "rtsp://", 7) ==
0) {
                                                      
                                                      
              
         /* URL is spec'd to terminate with a NULL;
don't trust it */

QUICKER:

src/demuxers/demux_qt.c src/demuxers/demux_qt.new2.c
--- src/demuxers/demux_qt.c     2004-06-15
23:22:34.000000000 +0200
+++ src/demuxers/demux_qt.new2.c        2004-06-22
14:43:20.000000000 +0200
@@ -1458,8 +1458,8 @@
     if (current_atom == RDRF_ATOM) {
                                                      
                                                      
              
       /* if the URL starts with "http://", copy it */
-      if (strncmp(&ref_atom[i + 12], "http://", 7) == 0
-        || strncmp(&ref_atom[i + 16], "rtsp://", 7) ==
0) {
+      if (strncmp(&ref_atom[i + 16], "://", 3) == 0
+        || strncmp(&ref_atom[i + 20], "://", 3) == 0) {
                                                      
                                                      
              
         /* URL is spec'd to terminate with a NULL;
don't trust it */
         ref->url = xine_xmalloc(BE_32(&ref_atom[i +
12]) + 1);


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=109655&aid=977510&group_id=9655