[xine-devel] Lots of deprecation warnings when running automake

[Xavier B. <xa...@ba...>]

Hi,

automake is giving a lot of warnings on Fedora 25 and probably others. Here's some output trimmed to remove the duplicates :

1/
configure.ac:225: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and its use is discouraged.
configure.ac:225: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
configure.ac:225: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.

2/
configure.ac:1166: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')

3/
src/input/Makefile.am:110: warning: source file '../demuxers/asfheader.c' is in a subdirectory,
src/input/Makefile.am:110: but option 'subdir-objects' is disabled
automake: warning: possible forward-incompatibility.
automake: At least a source file is in a subdirectory, but the 'subdir-objects'
automake: automake option hasn't been enabled.  For now, the corresponding output
automake: object file(s) will be placed in the top-level directory.  However,
automake: this behaviour will change in future Automake versions: they will
automake: unconditionally cause object files to be placed in the same subdirectory
automake: of the corresponding sources.
automake: You are advised to start using 'subdir-objects' option throughout your
automake: project, to avoid future incompatibilities.


I'm attaching a patch for 2/, I'll try and look at the 2 others, but feel free to beat me to it.

Additionally, some possible portability issues are also showing up :

misc/Makefile.quiet:1: warning: ':='-style assignments are not portable
misc/Makefile.quiet:1: warning: if $(findstring GNU,$(shell $(MAKE: non-POSIX variable name
misc/Makefile.quiet:1: (probably a GNU make extension)

contrib/Makefile.am:18: warning: shell cd @srcdir@; pwd: non-POSIX variable name
contrib/Makefile.am:18: (probably a GNU make extension)

Regards,
Xavier