Re: [xine-devel] [PATCH 2/4] Added configuration parameter for enabling/disabling XLockDisplay calls

[Andreas A. <ya...@in...>]

Am Dienstag, den 31.01.2012, 15:07 +0000 schrieb Darren Salt:
> I demand that Andreas Auras may or may not have written...
> 
> > Added configuration parameter
> 'video.output.vdpau_enable_buggy_xcb_workaround'
> > for enabling/disabling XLockDisplay calls in VDPAU video output driver.
> > It is enabled by default like it is in the current implementation.
> > But on many systems now it works fine without these locks. Disabling it by
> > configuration is easier as changing source code.
> 
> > +#define DO_LOCKDISPLAY if (guarded_display) XLockDisplay(guarded_display);
> 
> That should be wrapped in 'do { ... } while (0)' and without the trailing
> semicolon: this kind of macro needs to be a single otherwise-complete
> statement so that it can be used as an ordinary statement, avoiding odd
> side-effects in, for example, 'if' blocks.
> 
> Not at all incidentally, I've just fixed up semicolon usage there.
Thanks. This is of course better style.

> 
> (Can we sufficiently easily programatically determine whether the locking is
> required?)
> 
Well all my ubuntu systems never have a problem with buggy xcb library.
Maybe other can tell what is really going wrong on affected systems.