Re: [xine-devel] [PATCH] Possible fix for deadlock in xine-ui

[Reinhard N. <rn...@gm...>]

Hi,

Am 13.03.2011 17:09, schrieb Chris Rankin:
> --- On Sun, 13/3/11, Reinhard Nissl<rn...@gm...>  wrote:
>> So it looks like 95 % of all XLock-/UnlockDisplay() calls
>> in xine-ui are superfluous but don't hurt either. Some of
>> them actually serve to protect a couple of xine-ui threads
>> from doing anything bad due to the design of xine-ui and
>> could be changed to some other mutex locking calls as well.
>
> It looks like Fedora 14's xine-ui-0.99.6-25 package doesn't use XScreenSaverQueryInfo() at all in order to block the screensaver. This might explain why it is unaffected by the deadlock, despite still having large numbers of XLockDisplay()/XUnlockDisplay() calls.
>
> I suppose the best fix is to review xine-ui and remove all the superfluous locks completely, but until that happens I think that adding the extra lock in video_window_get_ssaver_idle() is entirely consistent with the current broken strategy. (And makes xine-ui work again, too.)

I agree with you. I have that patch in meanwhile since a couple 
of hours. Couldn't use xine-ui otherwise with openSUSE 11.4.

Bye.
-- 
Dipl.-Inform. (FH) Reinhard Nissl
mailto:rn...@gm...