[xine-bugs] [Bug 63] New: Bugfix for Windows port.

[<bug...@xi...>]

http://bugs.xine-project.org/show_bug.cgi?id=63

           Summary: Bugfix for Windows port.
           Product: xine-lib
           Version: unspecified
          Platform: i386/x86
        OS/Version: Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: Core / Backend
        AssignedTo: xin...@xi...
        ReportedBy: car...@li...


Created an attachment (id=24)
 --> (http://bugs.xine-project.org/attachment.cgi?id=24)
Fix for this bug

I would like to suggest these fixes for making xine-lib-1.1.10.1 working under
Win32/Win64:

src/demuxers/demux_ac3.c:
src/demuxers/demux_dts.c:
src/libw32dll/wine/pe_image.c:
I added the inclusion of malloc.h, otherwise the alloca() is not found.
I had also added the type casting where alloca() had been called, for fixing
some warnings.


src/input/vcd/libcdio/FreeBSD/freebsd.c:
The arpa/inet.h does not exist under Win32/Win64.
So I moved it after the "#ifdef HAVE_FREEBSD_CDROM" line.

src/xine-engine/xine.c:
With Pthreads for Win32/Win64 I cannot compare two pthread_t items because they
are implemented as structures.
So, I made a function cmp_pthread_t() for doing this task.

In my opinion there is a vulnerability into function xine_init().
The problem comes from the fact that into xine_probe_fast_memcpy() there is a
call to xprintf, which excutes some actions to this->log_lock.
But the "log_lock" field is uninitialized.
Under Windows, the xine_init() always crashes because that type is implemented
as a structure, so the lock receives a NULL pointer and the execution is
halted.


include/xine.h
The <sys/time.h> does not exists under Microsoft Platform SDK.
Hopefully, it exists into w32api, that's why I can compile successfully
xine-lib under MSYS.
So I just checked if we are compiling under MSVC, because PSDK can be used only
with this compiler.


-- 
Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.