[xine-devel] Is video_overlay_t's button array supposed to be used for...?

[Diego 'F. <fla...@gm...>]

I've been working on reducing the size of structures for xine-lib in a
split branch that would probably be a base for 1.2 series (as it broke
the public ABI by reordering some public structures).

Now, I've been looking at the 32-elements button array in
video_overlay_t (video_overlay.h:90); the code never references that
array, and neither do gxine nor xine-ui.

Is it supposed to be used for.. ?

Especially since it's not being used by default afaics, it would
shorten the video_overlay_object_t from 86KB to 40 bytes, so, if it's
not used, it should be cleaned up.
If it's used by some frontends, beside documenting it, it should be
probably changed to a dynamic array, as a single vo_button_t is 2.5KB,
and having 32 allocated just for the sake of it doesn't sound like a
sane idea...

--=20
Diego "Flameeyes" Petten=C3=B2
http://farragut.flameeyes.is-a-geek.org/