From: Diego 'F. <fla...@ge...> - 2006-12-24 21:15:20
|
On Sunday 24 December 2006 22:06, Reinhard Nissl wrote: > The fix for the other race condition is to check driver_open after > regaining driver_lock. When driver_open is no longer true then the code > block to execute must be redetermined. I'm not sure if a goto call would be a good choice there. Considering this->driver_lock is unlocked only to call ao_fill_gap, also, I= 'd=20 say it would be simpler to have it as a recursive mutex. Besides that, I'd prefer a do while cycle rather than a goto call. =2D-=20 Diego "Flameeyes" Petten=C3=B2 - http://farragut.flameeyes.is-a-geek.org/ Gentoo/Alt lead, Gentoo/FreeBSD, Video, Sound, ALSA, PAM, KDE, CJK, Ruby ... |