Re: [xine-user] xine 1.0.2 uses -fno-inline-functions with GCC < 3.4?

[Darren S. <li...@yo...>]

I demand that Malte Gell may or may not have written...

> am just about to install Xine 1.0.2 when I read the following in the
> Changes:

> "use -fno-inline-functions with gcc < 3.4.0 (bug known to be in 3.3.5)"

Hmm. That's my doing...

> Is this bug GCC 3.3.5 specific or does it affect the whole GCC 3.3 series?

The bug is definitely still there in gcc 3.3.6 (I've just checked by
attempting to compile a xine-lib CVS snapshot from 28 April). As for when the
bug was introduced, I have no idea.

(I've not tried building 1.1.0 with gcc-3.3.)

> Would be nice if someone knows more about it, I still use GCC 3.3.1 and
> often use -finline-functions (up to now...:-)

It was triggered by an always_inline in mpegvideo.c (libavcodec). For more
information:
<URL:http://sourceforge.net/mailarchive/forum.php?thread_id=7142930&forum_id=7131>

However, this code has been altered since the configure check was added; in
1.0.2, the bug isn't triggered, so the check can safely be removed (but I'd
prefer to leave it in since it guards against new code which would otherwise
trigger the bug).

-- 
| Darren Salt | d youmustbejoking,demon,co,uk | nr. Ashington,
| Debian,     | s zap,tartarus,org            | Northumberland
| RISC OS     | @                             | Toon Army
|   <URL:http://www.youmustbejoking.demon.co.uk/progs.packages.html>

No matter how much you know, you'll never know enough.