Re: [xine-devel] dvd time seek [was: new releases? -- bug report]

[Michael R. <mr...@us...>]

[I have been sending this from the wrong account. My appologies to  
the moderator, please ignore the previous post.]

Hi Miguel,

>> On DVDs, things could be improved considerably, because the IFOs hold
>> a table mapping timecodes to stream positions. But using this would
>> require seeking to be implemented in the input plugin, not in the
>> demuxer as it is now.
>
> I'm attaching a patch for doing exactly that.

That's great! :)

> However, due to my limited (or lack of...) knowledge of how dvdnav  
> works i can only do some ugly hacking there. Since the time seeking  
> function was unimplemented, i wrote one based on the sector  
> version. it uses some tables and interpolation and it seems works  
> (very little testing) but it may not be the correct way. besides it  
> doesn't seem to be very accurate (interpolation error?).
>
> so... would you mind checking the dvdnav part of the patch for me? ;-)

Your code appears to be correct, but as far as I understand it, you  
only use the start and end time of the cells, interpolating in  
between. This will work more or less, but there is a more accurate  
time to VOBU table available. But I think we can still commit your  
changes now and improve on it later. Could you give me until tomorrow  
to get your patch into libdvdnav CVS?

Michael