From: Jason T. <ta...@sa...> - 2005-09-21 19:57:13
|
If I use a driver that has VO_CAP_CROP (like Xv), and specify a crop offset using XINE_PARAM_VO_CROP_LEFT, for example, blended overlays looks fine. However, if I use a driver without VO_CAP_CROP (like opengl), when I specify a crop offset, video_out will crop the image, which is fine, however it does not appear to adjust for the crop offsets when the overlay is blended. As a result, DVD menus overlays are in the wrong spot. It seems that it should just be a matter of offsetting the x and y members of vo_overlay_t with the crop offsets if the vo driver doesn't support VO_CAP_CROP. I looked briefly at the code and it wasn't immediately obvious on how to do that, so I thought I would post here first in the hopes that it's a 30 second fix for someone who has a clue. :) The bug is illustrated here: http://sault.org/~tack/xine-opengl-crop-overlay-bug.jpg This is using the opengl vo with XINE_PARAM_VO_CROP_LEFT set to 100. As it happens, the underline is exactly 100 pixels to the right of where it needs to be. :) Cheers, Jason. |