Re: [xine-devel] [RFC] xine-lib and CFLAGS/CXXFLAGS

[Diego 'F. <fla...@ge...>]

On Wednesday 14 September 2005 13:56, Marcelo Jimenez wrote:
> Well, like I said in a previous post, it would be nice to be able to
> set the optimization level to -O0 for debug. -O1 or -O (which is the
> same) sometimes hides variables, so it is not always good for debug.
Well -O0 use to break things from times to times, so I'm not sure I would u=
se=20
it for debugging, anyway, that's not a problem I think at this point, as yo=
u=20
can select whatever CFLAGS you want (-fomit-frame-pointer is needed only wi=
th=20
pic enabled on x86, without pic debug is still possible).

> There should be a nice set of default values for optimization, so I
> don't think it is a good idea to remove the CFLAGS completely. Then if
> the user wants to mess, give him a configure time option to do so.
Exactly the point ./configure by default enables the optimizations exactly =
as=20
before, ./configure --disable-optimizations disable the extra optimization=
=20
flags and give a clean CFLAGS environment that can be controlled by user (a=
nd=20
by our ebuild).

> Could you explain why there would be lots of conditionals on the code?
Well the solution 2 would require tests inside configure.ac parts where CFL=
AGS=20
are set. The patch I sent instead moves all the CFLAGS mangling in another =
m4=20
file, so the only test is wether to call or not the function that mangles=20
them.

> In my opinion, if someone messes with default, he could get a
> configure time warning like: "Heye, you better know what you're
> doing!!! Don't come crying to complain after!" :)
Well if someone tries to compile mplayer with the CFLAGS used by xine-lib=20
right now is probably going to have bad segfaults all around... xine-lib fr=
om=20
this point of view is more solid.
Still, removing the extra flags and mangling them in the ebuild seems to ha=
ve=20
solved the "xine-ui crashes from time to time" kind of problem for users, s=
o=20
there can be something in those flags that have bad interactions with other=
=20
things like CPU or GCC or whatever.

=2D-=20
Diego "Flameeyes" Petten=F2
Gentoo Developer - http://dev.gentoo.org/~flameeyes/
(Gentoo/FreeBSD, Video, Gentoo/AMD64, Sound, PAM)