From: Hans-Dieter K. <hd...@t-...> - 2005-02-20 22:05:31
|
Hi, Thomas Hellstr=F6m wrote: > Hi! >=20 > Attached is a small patch, which is part of Kendall Bennet's=20 > (Scitechsoft) big XvMC update / optimization. >=20 > Since this one touches code that I don't know anything about, could=20 > somebody that does have a look at it? Basically it removes some floatin= g=20 > point operations in favour of integer ones. This is because on some=20 > non-floating-point capable hardware these operations degrade performanc= e. >=20 > Best regards > Thomas Hellstr=F6m >=20 >=20 I also don't know about the particular code. But from my "C" knowledge,=20 I'd like to mention two things: 1) Be aware of integer overflows, and of course, underflows. 2) Concerning this, order of expression evaluation is not absolutely=20 guaranteed, even if parentesized btw. (the order of "*" and "/" near=20 line 1002 was obviously changed due to integer evaluation). Hans-Dieter |