Re: [xine-devel] post plugins: how do I change cropped area correctly?

[Reinhard N. <rn...@gm...>]

Hi,

Darren Salt wrote:

>>Attached you'll find my centre cut out patch for expand post plugin.
> 
> I think that the centre cutout code should be a separate plugin *or* it
> should be possible to disable the 16:9 to 4:3 conversion. Perhaps it should
> depend on the display area's aspect ratio and, possibly, also on whether this
> is variable?

Well, in full screen mode this doesn't matter, but you are right: it 
does matter when used in window mode. I'll try to create something new ;-)

> Some bugs (apparent when using vdr's menus)
> 
>   * Enabling auto-shift causes the overlay to be shifted down too far. Given
>     that it's already stretched to fit, it shouldn't be moved at all.

Is this the case when centre cutout mode is active at that time?

I've added some code to disable overlay shifting while centre cutout is 
active but I'm not sure whether it is working because I didn't (want to) 
find a test case.

>   * Try to move an overlay too far up and a segfault happens.

Please explain this in more detail. I don't understand what you mean 
with "move an overlay too far up".

I've discoverd a segfault myself when I tried to play a HDTV stream. 
I'll have a look at it.

> I'm using xine-lib from the xine-1_0 branch (snapshot is from very early
> today) plus the vdr-xine 0.7.0 patch and my XML and PNG fixes.
> 
> (Hmm. I've seen the centre cutout code triggered on News 24 - which is odd,
> given that that channel is always 16:9. Still, it appears to be working...)

Well, that's the odd thing. The code is currently triggered by testing 3 
points. Maybe I should add some more test points.

Another solution would be to ignore the test points in the case where 
the stream contains AFD headers. I was told that this should be the case 
in UK. Can you provide me some sample recordings (VDR directories, each 
~ 5 MB)?

Bye.
-- 
Dipl.-Inform. (FH) Reinhard Nissl
mailto:rn...@gm...