Re: [xine-devel] _x_flush_events_queues

[Thibaut M. <thi...@gm...>]

On Fri, 21 Jan 2005 17:30:56 +0100, Stefan Holst <ma...@s-...> wrote:
> Thibaut Mattern wrote:
> > On Fri, 21 Jan 2005 13:19:00 +0100, Stefan Holst <ma...@s-...> wrote:
> >>imho this should be made optional to prevent deadlocks in
> >>single-threaded frontends. maybe something like
> >>XINE_ENGINE_PARAM_FLUSH_EVENTS?
> >
> >
> > I would prefer to just delete this function.
> > If you remove the flush stuff, a frontend (using the listener thread)
> > has no way to know if it has received all the events related to the
> > xine_open() call.
> > If you think about that problem, why not introduce a new event
> > XINE_EVENT_UI_OPEN_FINISHED to mark the end of error events sent
> > during the open call ?
> > The goal is to concatenate all error messages and display only one
> > popup on error.
> 
> patch is attached for review.
> 
> also updated ruine, it shouldn't segfault in line 20 anymore ;)

I would like to hear comments from others, and especially Bastien
because he wrote the flush function iirc.

> RY
> Stefan

Thibaut