Re: Re: Re: [xine-devel] amd64 fixes

[Bastien N. <ha...@ha...>]

On Thu, 2004-06-03 at 16:45 +0000, tma...@no... wrote:
> [...]
> >> The dxr3 patch looks very suspicious (same for video_out_opengl.c):
> >> +#if SIZEOF_INT == 2
> >>        int window_showing = (int)data;
> >> +#elif SIZEOF_INT == 4
> >> +      int64_t window_showing = (int64_t)data;
> >> +#endif
> >
> >This is pointer to int and back casting, see my mail to Michael about
> >this.
> 
> As I understand "SIZEOF_INT == 2", and if the unit is a byte,  you're
> checking if you're on a 16 bits cpu.
> That's why it looks suspicious to me ;-)
> 
> If the sizeof unit is 16bits, this should be mentionned IMHO because
> this code is not understandable.

http://www.geocrawler.com/mail/msg.php3?msg_id=3761463

It's twice the size of a char...

---
Bastien Nocera <ha...@ha...> 
Her hair glistened in the rain like nose hair after a sneeze.