From: Stephen t. <st...@to...> - 2004-07-09 21:01:14
|
On Fri, 2004-07-09 at 16:45, Brad Campbell wrote: > The only reason I explicitly define the AM_CONDITIONAL in both cases is that at some point configure > threw a warning at me telling me HAVE_SDL was not defined as that was probably a result of it being > conditional. Thus I stuck the extra AM_CONDITIONAL in there and the warning went away. I figured I > should err on the side of caution. Belts and braces so to speak. Remember that I wanted this to make > no default changes to anything the user might see. > > There are still issues with the patch I sent as I notice when I do a configure --help I get > --disable-alsa listed twice. It was more a post for comment kind of thing. > > Really, the disable call should be in the appropriate .m4 if one exists I guess. (sdl and alsa at least) > > The main issue is at the moment, some of the items detect they are being cross compiled and just > include by default. > > alsa.m4: AC_MSG_RESULT(no),[echo $ac_n "cross compiling; assumed OK... $ac_c"]) > arts.m4:],, no_arts=yes,[echo $ac_n "cross compiling; assumed OK... $ac_c"]) > sdl.m4:],, no_sdl=yes,[echo $ac_n "cross compiling; assumed OK... $ac_c"]) > And so on... > > Suggestionn welcome. (Lessons in autoconf appreciated!) Well for starters lets get the disable calls in the configure.ac file. Once they are there we can begin to transfer them to the .m4 files if they exist or we can create one. Do you understand the one that I did for SDL? Stephen |