From: <jue...@gm...> - 2004-05-18 12:31:09
|
On Tuesday 18 May 2004 04:34, Miguel Freitas wrote: > On Mon, 17 May 2004 14:49:36 -0300, Miguel Freitas <mfr...@gm...>=20 wrote: > >=20 > > On Mon, 17 May 2004 17:50:35 +0100, James Courtier-Dutton > > <ja...@su...> wrote: > > > I have added a "parameters api" for the cut off frequency for the > > > Sub-woofer when upmixing. (in cvs now) > > > I can't find any Frontends that let someone change the parameters for= an > > > audio_filter, or a visualisation plugin. > > > > > > Do you know of any that I can use to test this parameter api ? > >=20 > > none yet. > > but i'm halfway of finishing kaffeine support, i might have a patch > > ready tonight (if i get home early). >=20 > patch sent to J=C3=BCrgen (and attached for reference). I can see your > cut_off_freq now ;-) >=20 > we now have another problem. i believe i've found a bug in xine-lib > post plugin helpers, some variables (rate, mode, bits) were not > initialized when plugin was created and first wired to audio_out port. > rewiring it resulted in audio_out port being opened with rate=3D0, > mode=3D0 and bits=3D0. >=20 > i'm not so sure about my fix, so it would be nice if Michael could > give a small help here ;-) >=20 > this rewiring logic seems a bit tricky. i know we must rewire it > backwards (from audio_out to stream) so on-the-fly rewiring is > possible. still, using the current values of rate/mode/bits to open > the new port as in post.c:post_audio_rewire() seems strange... >=20 >=20 > with this patch applied, kaffeine will segfault when using older xine > versions (older than cvs!). this is pretty bad given that is not > currently possible to do a runtime test for which RC version is being > used. we should think of some workaround to avoid people complaining > when kaffeine (or xine-ui, as soon as we write support for audio post > plugins there) is upgraded. Miguel's patch was just commited. Current Kaffeine CVS provides now a dialo= g=20 to set audio filter plugins (under Settings|Postprocessing Filters). But gi= ve=20 Sourceforge some hours ;-) =2D-=20 regards J=C3=BCrgen Kofler http://kaffeine.sourceforge.net |