Re: [xine-devel] [PATCH] seeking support for Matroska files

[Thibaut M. <tma...@no...>]

Hi Moritz,

On Mon, 2004-04-26 at 09:51, Moritz Bunkus wrote:
> Heya,
> 
> > The code looks quite good.
> 
> Thanks.
> 
> > Some things could be improved like the realloc for each new index entry,
> > and the linear search inside the index entry list (the AVI demux uses a
> > binary search, and alloc more than one entry at once)
> 
> Fair enough. Here's the second incarnation which allocates space 1024
> index entries at once and which uses a binary search for seeking. My
> chapters patch still applies on top of this with offsets.

I've commited this patch. I've fixed some little issues with the ebml
parser, and the check_newpts function. Now all my 4 mkv streams play ;)

> > I think i will commit the patch soon.
> 
> Thanks :)
> 
> > It seems that the original code was not too complicated to understand
> > ;-)
> 
> Nope, it was fine. The thing that got me confused for an hour or so was
> the part that is '#ifdef 0'ed which handles meta seek stuff... But that
> was probably the biggest problem.

There is still some work to do because the whole file is scanned at
start.

> Mosu

thanks for the patches,
Thibaut