[xine-devel] Re: [xine-cvs] CVS: xine-lib/src/input input_cdda.c,1.50,1.51

[Bastien N. <ha...@ha...>]

Hello Robin,

On Wed, 2004-04-21 at 17:43, Robin KAY wrote:
> Update of /cvsroot/xine/xine-lib/src/input
> In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv27642
> 
> Modified Files:
> 	input_cdda.c 
> Log Message:
> Exclusive open(2) on CD device fails if a filesystem has been mounted.
> Affects at least Solaris 9 and Linux 2.6 (latter according to post by
> Bastien Nocera). Added support for skipping data track on Solaris.

I don't think this O_EXCL removal is necessary. It should be handled
differently for Mixed-CDs (like CD Extras).

You can't mount audio-only CDs. The correct fix would be for xine to
check if the CD is mounted if the open() returns EBUSY, and ask the user
if he wants to umount the device before playing back (that bit should be
done by the front-end).

Simply removing O_EXCL isn't the right fix in this case.

---
Bastien Nocera <ha...@ha...> 
Shots rang out, as shots are wont to do.