From: Miguel F. <mi...@ce...> - 2004-02-18 02:34:30
|
Hi Rocky, On Tue, 2004-02-17 at 20:36, R. Bernstein wrote: > Goetz Waschk, a mandrake person, passes along some patches they use > for xine-lib. The patches are here: > > http://cvs.mandrakesoft.com/cgi-bin/cvsweb.cgi/SPECS/xine-lib > > (...) > It would be good if some xine configuration/compiler expert would go > over these and commit or report back. However if there is no response > (which means no objections), I'll probably apply in a couple of days. i'm no configuration/compiler expert but they look very good to me. i would take a little care with the 64bit fixes patch though. i'm not sure the goom part is correct, using uintptr_t (is it the same as unsigned int *?) might give a different pointer math that old (wrong) code that cast to (unsigned int). shouldn't (char *) be used instead? and while i agree with the change to alphablend.c, why is the old code wrong? regards, Miguel |