Re: [xine-devel] [rhollan@golden.net: xine-lb 1rc3a patch to make OSD text work.]

[Rene S. H. <rh...@go...>]

Frantisek Dvorak wrote:


> Can you please also test attached patch, if does it help? (it will work
> only on the little-endianness systems)
> 


Yes, the patch below works.

Again, it looks like little endian systems need to swap the unicode 
returned by iconv().

Cheers,

Rene



> 
> ------------------------------------------------------------------------
> 
> Index: src/xine-engine/osd.c
> ===================================================================
> RCS file: /home/valtri/CVS/xine-lib/src/xine-engine/osd.c,v
> retrieving revision 1.1.1.5
> diff -u -u -r1.1.1.5 osd.c
> --- src/xine-engine/osd.c	9 Dec 2003 08:31:37 -0000	1.1.1.5
> +++ src/xine-engine/osd.c	25 Jan 2004 20:31:41 -0000
> @@ -891,7 +891,7 @@
>    }
>  
>    /* prepare conversion to UCS-2 */
> -  if ((osd->cd = iconv_open("UCS-2", encoding)) == (iconv_t)-1) {
> +  if ((osd->cd = iconv_open("UCS-2LE", encoding)) == (iconv_t)-1) {
>      xprintf(osd->renderer->stream->xine, XINE_VERBOSITY_LOG,
>  	    _("osd: unsupported conversion %s -> UCS-2, no conversion performed\n"), encoding);
>      return 0;
>