[xine-devel] Bugfix for radeon_vid?

[Patrick C. <er...@ps...>]

Hi list,

after playing around a bit with xine's vidix output, I found a solution
for my problem with strange colors in the video (it appeared like a
color remapping, having blue-skined people, red sky, ...). After my
small change (see below), the colors are correct now. I have a ATI
graphics adaptor in my notebook, from which lspci says:

01:00.0 VGA compatible controller: ATI Technologies Inc Radeon Mobility
M6 LY (prog-if 00 [VGA])
        Subsystem: Dell Computer Corporation: Unknown device 00e4
        Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop+
ParErr- Stepping+ SERR+ FastB2B-
        Status: Cap+ 66Mhz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
        Latency: 32 (2000ns min), Cache Line Size: 0x08 (32 bytes)
        Interrupt: pin A routed to IRQ 11
        Region 0: Memory at e0000000 (32-bit, prefetchable) [size=128M]
        Region 1: I/O ports at c000 [size=256]
        Region 2: Memory at fcff0000 (32-bit, non-prefetchable) [size=64K]
        Expansion ROM at <unassigned> [disabled] [size=128K]
        Capabilities: [58] AGP version 2.0
                Status: RQ=48 Iso- ArqSz=0 Cal=0 SBA+ ITACoh- GART64-
HTrans- 64bit- FW- AGP3- Rate=x1,x2,x4
                Command: RQ=32 ArqSz=0 Cal=0 SBA+ AGP+ GART64- 64bit-
FW- Rate=x1
        Capabilities: [50] Power Management version 2
                Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-)
                Status: D0 PME-Enable- DSel=0 DScale=0 PME-

Here my change to the current cvs of xine-lib:

Index: src/video_out/vidix/drivers/radeon_vid.c
===================================================================
RCS file: /cvsroot/xine/xine-lib/src/video_out/vidix/drivers/radeon_vid.c,v
retrieving revision 1.13
diff -u -r1.13 radeon_vid.c
--- src/video_out/vidix/drivers/radeon_vid.c    16 Nov 2003 17:18:10
-0000      1.13
+++ src/video_out/vidix/drivers/radeon_vid.c    1 Dec 2003 16:15:10 -0000
@@ -806,7 +806,7 @@
        CAdjBCb = sat * OvHueCos * trans[ref].RefBCb;
        CAdjBCr = sat * OvHueSin * trans[ref].RefBCb;

-#if 0 /* default constants */
+/* #if 0 /\* default constants *\/ */
        CAdjLuma = 1.16455078125;

        CAdjRCb = 0.0;
@@ -815,7 +815,7 @@
        CAdjGCr = -0.8125;
        CAdjBCb = 2.01708984375;
        CAdjBCr = 0;
-#endif
+/* #endif */
        OvLuma = CAdjLuma;
        OvRCb = CAdjRCb;
        OvRCr = CAdjRCr;


Maybe, someone of you can check it and maybe integrate it in future
versions of xine, so that other users with the same hardware could
benefit of.

CU/all

P.S.: As I do not have the time for reading xine-devel, I would be happy
if someone could drop me a short note, if the patch is
accepted/rejected/etc.
-- 
Patrick Cernko | mailto:er...@er... | http://www.errror.de
Quote of the Week: "/vmlinuz does not exist.
                    Installing from scratch, eh?"
                   (Debian Kernel Installation)