Re: [xine-devel] xine ffmpeg copy (Was Re: Fwd: that bad old .mov file)

[R. B. <ro...@pa...>]

James Stembridge writes:
 > > Hope it gets sorted out. Interesting to me that the approach was not
 > > to sync (or finish the sync) and then look to see if it fixed, but fix
 > > in local copies first, then sync and possibly add a patch if it still
 > > needed.
 > 
 > No, that's not what I did, how can you say if I did or didn't check
 > ffmpeg CVS before trying to fix it myself? 

Sorry. You didn't mention looking at ffmpeg CVS so I assumed you
didn't. If you did, keep up the good work!

 > Or are you suggesting we
 > should blindly sync every time there is a problem?

What I personally do when I discover a problem in software I'm using
is check the latest version, and look over the NEWS or Changelog to
see if there might be something related.

But sure, creating a patch in a local version may be expedient to
understand what's wrong. 

 > 
 > I checked ffmpeg CVS, which also had the problem. I worked out a fix and
 > committed it to our copy, and was in the process of sending the patch to
 > ffmpeg-devel when I realised that the fix might actually have side
 > effects (damn I hate them, we should all code in Haskell instead ;)
 > Rather than trying to figure it out and check other files I decided to
 > sleep on it and come back to it later. In due course I will fix the
 > problem properly and ensure the appropriate fix is sent upstream.

Okay, thanks for the explanation. Keep up the good work.