From: Michael R. <mr...@us...> - 2003-10-15 16:24:31
|
Hi Frantisek, > > Could you try changing line 277 of input_file.c to something like: > > > > if ((strncasecmp (mrl, "file:", 5)) && (strstr(mrl, ":/") < > > strchr(mrl, '/'))) { > > Great, very simple solution and it works. :-) Thanks for committing it. > > > And what do you thing about escaping MRL inside input plugins? I > > > think they return bad MRLs now (according to our scheme with '%' > > > escapes). > > > > What return do you mean? The get_dir() one? > > Yes, I do. xine-ui gets MRLs via xine_get_browse_mrls(), which calls > get_dir(). It would be "escaped" in input_file, IMHO. > But most of problems with MRLs are already solved by heuristics. I think we should leave it the way it is. Seeing %20 instead of a " " in the MRL browser will only confuse users. Michael -- "If you want to travel around the world and be invited to speak at a lot of different places, just write a Unix operating system." -Linus Torvalds |