Re: [xine-devel] updated XvMC patch

[Michael R. <mr...@us...>]

Hi Miguel,

> I'm attaching an updated XvMC patch for xine cvs. It seems close to
> something "committable" so I would like to hear opinions from other
> developers. (note: it will only be committed after RC1, i don't want
> to break the release).
>
> You can see that changes to the internal video_out api are now very
> small (just check what the patch does to video_out.h). Only one new
> frame method was added (proc_macro_block) and two new variables
> (picture_coding_type and macroblocks).

If you agree, I would like that reduced even more. I am thinking myself 
through some more flexible frame type handling in xine for past 1.0. In 
general, I would like frames to contain only the current set of engine 
metadata (vpts and the like), a format descriptor and a generic data 
pointer (similar to the current "base" member) then. This pointer would 
be cast to something based on the specific type of the frame to reveal 
the actual content.

I think something similar could be applied to XvMC here: Take everything 
that is needed specifically for XvMC frames (that would probably be 
proc_macro_block(), picture_coding_type and macroblocks currently), 
pack it into a new struct and store that struct in memory pointed to by 
a single new vo_frame_t member "content" (or similar).

This concept could then be expanded after 1.0 to be used for all sorts 
of frame types.

Michael

-- 
/* Thanks to Rob `CmdrTaco' Malda for not influencing this code in any
 * way.
 */
	2.4.3 linux/net/core/netfilter.c