From: James Courtier-D. <Ja...@su...> - 2003-09-24 16:17:49
|
R. Bernstein wrote: > Miguel Freitas writes: > > Hi Rocky, > > > > On Wed, 2003-09-24 at 10:19, R. Bernstein wrote: > > > Miguel Freitas writes: > > > > i would not recommend you to reimplement this function in xine-vcd. i > > > > have replaced the same code in input_dvd function about 10 months ago, i > > > > guess you should just call xine_demux_flush_engine() instead. > > > > > > Have done - would probably be good to mention in devel documentation somewhere. > > > > sure... just like the code itself, the documentation is also a community > > driven effort! (hint ;-) > > So is the VCD effort. So when you find "reimplimentation" code in the > DVD plugin it might also occur in other places like the the VCD plugin > (as was the case here), and it's okay to remove the "reimplimentation" > there as well or at least mention it. (hint ;-)> > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Welcome to geek heaven. > http://thinkgeek.com/sf > _______________________________________________ > xine-devel mailing list > xin...@li... > https://lists.sourceforge.net/lists/listinfo/xine-devel > > > I am working on implementing a "Detect media type" function call into libdvdnav. 1) DVD in DVDROM drive, encrypted. 2) DVD in DVDROM drive, non-encrypted. 3) DVD image on HD. 4) DVD files copy on HD. I don't see why I cannot add 5) VCD in DVD/CDROM drive 6) VCD image on HD. 7) VCD files copy (bin/cue) on HD. 8) Audio CD. 9) No media found. Then, we could very easily add a "PLAY DISC" button into xine, instead of having separate DVD,VCD,CDDA buttons, and it would look at the disc, and automatically select the correct input plugin to play it. The main reason for me adding a "detect media type" function, is so that we can provide better error messages to the user if a DVD fails to play. I do think that the initial reason for me adding this function can be extended, so that as soon as a user places a CD/VCD/DVD in the drive, xine will autodetect it and play it. Maybe this detection function is better placed elsewhere, so that both the VCD/CDDA and DVD plugins can use it. Maybe a better place for it might be in ./xine-lib/src/xine-utils? Cheers James |