From: Adrian S. <ad...@su...> - 2003-08-19 19:18:17
|
On Tue, 19 Aug 2003, Miguel Freitas wrote: > On Tue, 2003-08-19 at 08:50, Adrian Schroeter wrote: > > to the maintainers). The ffmpeg SSE/MMX fixes are still missing, but > > unfortunaly I am not freaky enough todo it myself, so I will bug someone > > else here later ... > > i don't know much about amd64, but instead of patching a lot of places > with: > > -#ifdef ARCH_X86 > +#if defined(ARCH_X86) || defined(ARCH_X86_64) > > why can't you just define both ARCH_X86 and ARCH_X86_64 at configure? because this would also affect the ffmpeg, but I do not have support for amd64 there yet, so a compile would fail ... and I thought that there will be maybe always some places, where a difference is (like loading windows DLLs what shouldn't be easy to implement, but maybe not impossible). > > The second patch is only interessting for packagers, so maybe you want > > simply ignore it. I use it to build a xine.rpm with plugins optimised for > > SSE and MMX and native (still working on Pentium I) in different pathes. > > you are right. in fact, i don't like this patch :) > why not just use the existing runtime optimization probing? IIRC it is not complete and I wouldn't be able to build plugins with -march=i686 for example. well, if you do not like, ignore it ;) (or put it in some patches-do-not-use directory) bye adrian ********************************************************************** Adrian Schroeter SuSE AG, Deutschherrnstr. 15-19, 90429 Nuernberg, Germany email: ad...@su... (811 mails already received today.) |