Re: [xine-devel] #ifdef LOG and xine->verbosity >= xxx change proposal [sample]

[Daniel Caujolle-B. <seg...@cl...>]

Hi Bastien,

Le mar 10/06/2003 =E0 12:58, Bastien Nocera a =E9crit :
> On Tue, 2003-06-10 at 10:44, Daniel Caujolle-Bert wrote:
> > Hi Guenter,
> >=20
> > Le mar 10/06/2003 =E0 01:47, Guenter Bartsch a =E9crit :
> > > hallo daniel,
> > >=20
> > >=20
> > > > > > +#define XINE_VERBOSITY_NONE                0x000000
> > > > > > +#define XINE_VERBOSITY_LOG                 0x000001
> > > > > > +#define XINE_VERBOSITY_DEBUG               0x000002
> > > > >=20
> > > > > [...]
> > > > >=20
> > > > > > +          if((xine)->verbosity & verbose)      \
> > > > >=20
> > > > > i think this is a small mistake - verbosity is not a bit vector=
 but a
> > > > > simple integer number (measuring the level of verbosity)
> > > > >=20
> > > >=20
> > > > 	Err, not a real mistake, bug here VERBOSITY_DEBUG should be 0xFF=
FFFF,
> > > > this way, devels can use ORed VERBOSITY, so more VERBOSITY "level=
s" can
> > > > be added (imagine you can trace demuxer only, or input player, an=
d such
> > > > things).
> > >=20
> > > verbosity is not a tool for developers but for end-users so definin=
g it
> > > as a bit verctor is way to complicated.
> > >=20
> >=20
> > 	Err, at contrary, i think verbosity is a devel tool. Why? because us=
ers
> > don't take care about xine's console output, they even lauch xine fro=
m
> > their desktop, without terminal emulator. They only use verbosity to
> > report bugs, unplayable streams and such problems. Look at lastest
> > reports they made on -user mailing list, they start to use verbosity=3D=
255
> > by themself.
> > 	Anyway, verbosity policy usage is up to UI, so i don't see any
> > complication here. UI can permit some numeric or "verbosity level
> > names".
> >=20
> > > for developer debug-output #define LOG is to be used
> > >=20
> >=20
> > 	At developement/bugfix stage, yes. No to trace a new user/engine
> > problem.
>=20
> The most important bit (that I didn't get yet). Is it possible to switc=
h
> the debug level up without recompiling?

	the lprintf() is exactly what #define LOG does, not intended to be set
unless it not defined (and release shouldn't define any LOG at all).
    About the verbosity, you can already use the API call

xine_engine_set_param(xine_t *, XINE_ENGINE_PARAM_VERBOSITY, level)

Cheers.
--=20
73's de Daniel, F1RMB.

             -=3D- Daniel Caujolle-Bert -=3D- seg...@cl... -=
=3D-
                        -=3D- http://naboo.homelinux.org -=3D-