Re: [xine-devel] #ifdef LOG and xine->verbosity >= xxx change proposal [sample]

[Daniel Caujolle-B. <seg...@cl...>]

Hi Guenter,

Le lun 09/06/2003 =E0 23:36, Guenter Bartsch a =E9crit :
> hallo daniel,
>=20
> > +#define XINE_VERBOSITY_NONE                0x000000
> > +#define XINE_VERBOSITY_LOG                 0x000001
> > +#define XINE_VERBOSITY_DEBUG               0x000002
>=20
> [...]
>=20
> > +          if((xine)->verbosity & verbose)      \
>=20
> i think this is a small mistake - verbosity is not a bit vector but a
> simple integer number (measuring the level of verbosity)
>=20

	Err, not a real mistake, bug here VERBOSITY_DEBUG should be 0xFFFFFF,
this way, devels can use ORed VERBOSITY, so more VERBOSITY "levels" can
be added (imagine you can trace demuxer only, or input player, and such
things).

> besides that it looks fine to me
>=20

	Nice.

Cheers.
--=20
73's de Daniel, F1RMB.

             -=3D- Daniel Caujolle-Bert -=3D- seg...@cl... -=
=3D-
                        -=3D- http://naboo.homelinux.org -=3D-