Re: [xine-devel] Bug#193542: libxine-dev problem with includes (fwd)

[Michael R. <mr...@us...>]

answering myself

Hi all,

> > > I guess that guy is right: includes in <xine/*> should be
> > > self-contained in that they reference other such includes with
> > > the "xine/" prefix. And maybe many of these (internal) includes
> > > shouldn't be installed at all...
> >
> > 	This was added by Tim, for win32 stuff. So, this should be fixed
> > (using XINE_COMPILE cpp directive), or better, fixed ;-)
> >
> > 	Also, you have to keep in mind about third party existing and
> > futur plugins, they (will) need to have access to xine's internals.
>
> I agree. The headers are needed for external plugin compilation. So
> we should simply guard all the includes in publicly available headers
> by #ifdef XINE_COMPILE. I did that here and I am compiling it right
> now. Shall I commit it, when things work?

I committed this public header cleanup to cvs. Quoting cvslog:

public header cleanup:
* regulate mutual inclusion based on XINE_COMPILE
* src/xine-engine/spu_decoder.h was unused
  -> make it the spu decoder API header and remove
     src/libspudec/spu_decoder_api.h
* mark some xine_stream_t members as unused for next cleanup

Siggi, could you check, if this is sufficient to close your bug?

Michael

-- 
panic("CPU too expensive - making holiday in the ANDES!");
	2.2.16 /usr/src/linux/arch/mips/kernel/traps.c