Re: [xine-devel] Re: [xine-cvs] CVS: xine-lib/src/input/libdvdnav Makefile.am,1.13,1.14 decoder.c,1.10,1.11 diff_against_cvs.patch,1.15,1.16 dvd_reader.c,1.4,1.5 dvdnav.c,1.28,1.29 highlight.c,1.14,1.15 dvdnav_internal.h.in,1.2,NONE ifo_print.c,1.3,NONE ifo_print.h,1.1,NONE

[Michael R. <mr...@us...>]

Hi James,

> What is the purpose of XINE_PATH_MAX?
> I cannot see any reason to use it at all.
> These lines in ./xine-lib/src/xine-utils/compat.h: -
> #ifndef NAME_MAX
> #define XINE_NAME_MAX   256
> #else
> #define XINE_NAME_MAX   NAME_MAX
> #endif
>
> #ifndef PATH_MAX
> #define XINE_PATH_MAX   768
> #else
> #define XINE_PATH_MAX   PATH_MAX
> #endif
>
> could so easily be changed to: -
> #ifndef NAME_MAX
> #define NAME_MAX   256
> #endif
>
> #ifndef PATH_MAX
> #define PATH_MAX   768
> #endif

I guess that was a precaution in case there would be a system you want 
to compile xine on that uses different names for these defines.
Don't know if it still makes sense.

Michael

-- 
panic("bad_user_access_length executed (not cool, dude)");
	2.0.38 /usr/src/linux/kernel/panic.c