Re: [xine-devel] patches for stdin non-block read, rawdv datarate, cmd line opts for deinterlace and aspect

[Daniel Caujolle-B. <seg...@cl...>]

Dan Dennedy wrote:
> On Thu, 2003-03-06 at 17:42, Daniel Caujolle-Bert wrote:
> 
> 
>>	I applied you patch against xine-ui CVS, i also fixed it since the 
>>deinterlace was not applied, and ratio was applied on animation stream ;-)
>>	
>>	Thanks for the patch.
> 
> 
> Yes, Siggi pointed these out to me, and I had been working on fixes
> myself. The aspect-ratio fix was easy and obvious. Not only was
> deinterlace not correctly applied, but I also face a problem with
> crashing on auto-start with a video on the command line. I have
> developed a less-than-ideal workaround, then I discarded it when I tried
> your CVS commit. Alas, your cvs commit is also crashing for me on
> 720x480 DV or MJPEG, but not on a small WMV.
	
	Okay. Sorry but i don't own such streams (except WMV), so i can't try to 
reproduce the crash. If you have some URL where i can get a crashy 
stream that would be nice.

> I can send a patch showing my workaround, but basically, I have to delay
> toggling interlace until the very last thing in event.c:on_start() with
> a slight delay beforehand. Or maybe that gives you an idea for a better
> solution? To do my workaround, a made a new struct start_options_t with
> auto_start and deinterlace fields that I passed as data through the
> callback.

	Yes.

Cheers.
-- 
73's de Daniel, F1RMB.

              -=- Daniel Caujolle-Bert -=- seg...@cl... -=-
                         -=- http://naboo.homelinux.org -=-