Re: [xine-cvs] CVS: xine-lib/src/libflac Makefile.am,NONE,1.1 decoder_flac.c,NONE,1.1 demux_flac.c,NONE,1.1

[Michael R. <mr...@us...>]

Hi Miguel,

> > > it needs automagic stuff to detect libflac...
> > > may someone take care of that? Stephen?
> >
> > Why not including libflac in xine-lib? Too big?
>
> i don't know, i just did the easiest thing.
>
> flac tarball is
>
>  1203647 Jan 16 17:43 flac-1.0.5_beta2.tar.gz
>
> but actually it should make sense to not include it in xine-lib:
> people that wants flac support are likely to have it installed
> already.  and flac has a stable documented api.
>
> not the same as libfaad: an user might download a quicktime6 file and
> will try to play it, without even knowing what faad/aac is.
>
> not the same as libffmpeg: it has a mutating api, types can be
> renamed from one week to the other. having a copy in xine-lib make
> things much easier.
>
> and so it goes. so yes, maybe we shouldn't include it. what do you
> think?

Very convinving reason. And since the tarball is quite big and will 
contain code which we never use (the flac encoding part), I agree it's 
better not to include it.

Michael

-- 
panic("Aarggh: attempting to free lock with active wait queue - shoot
 Andy");
	2.0.38 /usr/src/linux/fs/locks.c