Re: [xine-devel] [patch] plugin pre_init

[Miguel F. <mi...@ce...>]

Hi Siggi,

I don't want it to sound too competitive, that is, maybe just a
construtive competition :)

i think we don't have any fundamental disagreement here, so i would let
the decision on which method to use to the other developers...


On Fri, 2003-01-03 at 02:47, Siggi Langauf wrote:
> Attached patch shows how to get plugin config values static for the a52dec
> plugin.


doubt: i notice that you changed a52 to use cfg->lookup_entry. can't we
use cfg->register_xxx after the pre-initialization? otherwise it will be
impossible to set the callbacks for these a52 settings.


> This is what I had in mind as a solution to the vanishing codec settings.
> 
> advantages:
> - change to the plugin loader is minimal

ok, same with the flags method. basically just a new value added to
catalog.

> - pre_init function may do more than just register config values
>   (any useful suggestions?)

same here, usual init function gets called and it may do other things.
however pre_init has no context to store anything.


The patch is attached. it is bigger than yours, not only because i
increased plugin versions but i also changed a few other things:

- added two demuxer groups for testing (audio and games). this alone
reduces the number of demuxer plugins from 28 to 15. 

- liba52, libdivx4, libreal, w32codec and qt loader are marked with
PLUGIN_FLAG_ALWAYS_INITIALIZE in order to register their class settings.

- goom properties (fps, width and height) are made configurable and
plugin is marked with the new flag.


the demuxer grouping is not directly related to the pre_init stuff
(except for that case we discussed of xine_pre_init having to call each
of the virtual plugins). anyway i was testing it in my tree so it seemed
interesting to post.

regards,

Miguel