Re: [xine-devel] merger done

[Michael R. <mr...@us...>]

Hi Guenter,

> > some questions arose while adapting dxr3:
> > * What is the priority in the decoder info struct for? Does it
> > replace the old one (which is still there), making configurable
> > priorities impossible?
>
> the priority field in the decoder info struct is just used by the
> plugin loader to get an initial priority of the plugin (the idea is
> to avoid to call any code in the decoder plugin during 1st stage
> loading to keep the memory footprint down).

Reasonable. I removed decoder's private priority entries.

> configurable priorities will be possible again, but they need to be
> implemented in load_decoder.c . the basic idea is that load_decoder.c
> will register a priority config option for every decoder plugin it
> encounters.

Good idea.

> > * Why are some functions like get_identifier or can_handle still in
> > the decoder api? Shouldn't they be obsolete now?
>
> they are osbolute - feel free to remove them :)

I removed all interface version entries and the can_handle in the spu 
decoder api. Unfortunately the get_identifier functions are still 
called at some places to get plugin names. I kept them for now.

> > * Should we make all the init functions to all plugins static?
>
> definitely a good idea. ideally plugin should only export their info
> struct and nothing else to keep namespace pollution down.

Init functions are static now. Unless some 'static's have been forgotten 
somewhere, the namespace should be clean now.

Michael

-- 
/* When we have more time, we can teach the penguin to say 
 * "By your command" or "Activating turbo boost, Michael".
 */
	2.2.16 /usr/src/linux/arch/sparc/prom/sun4prom.c