Re: [xine-devel] xine fullscreen 'broken' with metacity

[Brian J. T. <bj...@ec...>]

Bastien Nocera wrote:

>Totem uses gnome-terminal's full-screen stuff (it's just a matter of
>setting another _NET_WM atom), but it's broken with the current metacity
>(2.4.0).
>
>I really don't know what the problem is. I added some comments to the
>bug, we'll see where it goes.
>
it's a little confusing, actually.  the current cvs of metacity and the 
latest stable release of gnome-terminal are the ones that display this 
new problem.  metacity's new panel behaviour screws up fullscreen xine, 
and gnome-terminal's fullscreen mode works fine (i.e. the panels aren't 
visible when gnome-terminal is in fullscreen mode).

it does indeed look like _NET_WM atom stuff, specifically 
_NET_WM_FULLSCREEN.  i somewhat copied the fullscreen code from 
gnome-terminal to xine, replacing the gtk/gdk portions by what i _think_ 
are the correct xlib equivalents, but it didn't work.  perhaps i put it 
in the wrong place in xine?  i stuck the atom-setting code in videowin.c 
in xine-ui, in the switch statement around line 300.  (the 
switch(gVw->fullscreen_req) statement).  i was really just playing 
around without knowing what i was doing, so i didn't seriously expect it 
to work.  anybody know exactly where it _should_ go?

thanks,
brian