Re: [xine-devel] new API: fix (width%16) != 0

[Miguel F. <mi...@ce...>]

Hi Ewald,

On Sun, 2002-07-07 at 15:48, Ewald Snel wrote:
> Hi,
> 
> Although this is probably not part of the public API, I would like to propose 
> adding something like 'int pitches[3]' to the vo_frame_s structure to fix 
> (width%16) != 0 related bugs. This would allow any pitch for future video 
> output plugins, which might require alignment on even larger blocks.
> 
> This will require a small change to all video decoder and video output 
> plugins. Any objections against this change?

Not at all, this is ok from my side.

I wouldn't invest too much effort to implement it though: what i saw in
xine is that the very few cases were non-multiple widths caused trouble
could be easily fixable in decoders. Of course, the clean solution is
doing what you suggested, but given that some decoders have similar
width limitations the problematic cases tends to be very rare (my
guess).

But if you want to fix this go ahead! also take a look at vidix headers
since the author seems to have cared about issues like that when
designing the api.

regards,

Miguel