From: Bill F. <bil...@mi...> - 2002-06-22 15:37:58
|
On Sat, 22 Jun 2002, Daniel Caujolle-Bert wrote: > Hi Bill, > > Bill Fink wrote: > > I saw a fix committed for the ppcasm_string.S problem, but please > > don't forget to do something about the "*_vid.*" files entry in the > > misc/xine-lib.spec file breaking the RPM build using "rpm -ta" when > > you don't have vidix installed. > > vidix driver /rule/ is already conditional, it's quite weird !. You can > disable vidix at rpm build time, export BUILD_ARGS=--disable-vidix > envvar then start rpm build. Hi Daniel, I think I understand. From the tarball, misc/xine-lib.spec.in contains: @HAVE_VIDIX_TRUE@%{_libdir}/xine/plugins/vidix/*_vid.* misc/xine-lib.spec contains: %{_libdir}/xine/plugins/vidix/*_vid.* So apparently whoever built the tarball has vidix support. Now if I install manually, after the configure step, misc/xine-lib.spec contains: #%{_libdir}/xine/plugins/vidix/*_vid.* since I don't have vidix installed on my system. However, when you do a "rpm -ta" on the tarball, it apparently uses the original xine-lib.spec file from the tarball, which kind of makes sense since the spec file is what guides the whole rpm process. I think the bottom line is that no conditionals should be used in the spec file, since otherwise there will be problems if the build environment of the system used to create the tarball is different from that of the user's system doing the install. The vidix stuff is the only thing using conditionals in the spec file at the moment. If people want optional items such as vidix in their RPMs, then they'll have to tweak the spec file themselves. A possible workaround for the vidix stuff would be to move the vidix plugins from the plugins/vidix subdirectory to the main plugins directory, so it would be covered by: %{_libdir}/xine/plugins/xineplug*.* in the files section of the xine-lib.spec. Or maybe that entry could be changed to: %{_libdir}/xine/plugins/* if that would also cover the vidix subdirectory and its contents. Similarly it would be nice if the entry in the files section of xine-ui.spec: %{_bindir}/xine* could be changed to: %{_bindir}/*xine* assuming that '*' would match zero characters (which I haven't tested). That would then also include aaxine which otherwise doesn't get included in the binary RPM built by "rpm -ta". -Regards -Bill |