Re: [xine-devel] echo on pause resuming

[Miguel F. <mi...@ce...>]

Hi Thibaut, Daniel,

On Thu, 2002-06-13 at 10:56, Mattern Thibaut wrote:
> > 	Well, witk alsa09 (oss not tested), i'm experiencing few
> > /echo/
> > after a pause cycle (one ore more pause cycles fix this
> > bad sound 
> > effect). Am i alone with this problem (of course, using
> > latest CVS, 
> > MPEG-II/AC3 streams, not really tested with other stream
> > types).
> 
> That's because audio_out buffers are now flushed when you press 'pause' (alsa09 + oss).
> The pause is immediate but this causes some problems on resume. I've
> posted a patch to solve this, and I still waiting comments from Miguel
> (it changes the metronom's behavior).

Hey, you don't have to ask me to commit these things! specially
bugfixes! :)

My latest cleanups to demuxers should make it easier to do the metronom
change you said (the helper function to send new pts accepts an
additional flag parameter, that might be used as "seek" hint).

I'm not sure how would it fix a pause problem though. No control buffers
are sent to do a pause/resume sequence... am i missing something from
your patch?

>From Daniel's comments, it looks like his card is getting into some
weird state (since more pause cycles fix the effect). It doesn't seem to
be related to the "multiple gap/2 fills" problem.

btw, do we really need to close/reopen oss on every pause?

btw2, can't alsa driver use snd_pcm_pause feature? (of course we need to
check if it's supported by hardware first)

regards,

Miguel