From: <bar...@t-...> - 2002-05-29 13:06:46
|
hi miguel, On 29 May 2002, Miguel Freitas wrote: > I don't see this much of common code in demuxers. It is true that > demuxers have a common and very special "logic", and this became more > obvious after mine and Thibaut work to improve seeking. But this logic > is highly dependent on demuxer oddities. just had a closer look and i must more-or-less agree with you here. i was hoping that it could be possible to more-or-less drag out all the thread-related code, but that really seems to be difficult and its questionable if this would really improve readability. problably doing some documentation in the xine hacker's guide about this could help a lot more here. > One thing that can improve demux programing are functions like > xine_flush_engine. This one abstracts the internals needed to reset the > engine, so changes there will be much easier in the future (instead of > having to edit all demuxers one by one). > > BTW, i think video_out are actually duplicating much more code. A helper > module (or function) to receive frame/window dimensions and return > output size, taking care of aspect ratio and zooming would be very > interesting... yeah, both ideas sound good to me. for demuxers a send_control_buffer() utility function could also be usefull which automatically sends a control buffer to audio and video fifo. i guess you're right that both cases could be improved by such rather small enhancements and a redesign is inappropriate for both cases. keep up the good work, guenter -- time is a funny concept |